cleanup the api surface #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to better reflect the design proposal in https://hackmd.io/@of-olm/B1cMe1kHj Signed-off-by: Bryce Palmer <everettraven@gmail.com>
everettraven
commented
Jan 26, 2023
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
anik120
reviewed
Jan 27, 2023
anik120
reviewed
Jan 27, 2023
anik120
reviewed
Jan 27, 2023
anik120
requested changes
Jan 27, 2023
Signed-off-by: Bryce Palmer <everettraven@gmail.com>
based on conversations had in review comments Signed-off-by: Bryce Palmer <everettraven@gmail.com>
rashmigottipati
added a commit
to rashmigottipati/catalogd
that referenced
this pull request
Nov 9, 2023
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 10, 2023
…ster (#209) * Add Ingress overlay to access `Catalog` contents outside of the cluster Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com> * Address review feedback Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com> * Address review feedback #1 Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com> * Address feedback #2 Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com> --------- Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Cleans up the api surface to better reflect the design proposal in https://hackmd.io/@of-olm/B1cMe1kHj by:
CatalogCachecustom resource/typePackagecustom resource/typeBundleMetadatacustom resource/type