Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add Ingress overlay to access Catalog contents outside of the cluster #209

Merged
merged 4 commits into from
Nov 10, 2023
Merged

✨ Add Ingress overlay to access Catalog contents outside of the cluster #209

merged 4 commits into from
Nov 10, 2023

Conversation

rashmigottipati
Copy link
Member

@rashmigottipati rashmigottipati commented Nov 7, 2023 •
edited
Loading

Closes #118

  • Create an Ingress overlay to expose Catalogd's HTTP endpoints outside of the cluster
  • Add documentation outlining the steps to fetch the catalog contents using Ingress

@rashmigottipati rashmigottipati requested a review from a team as a code owner November 7, 2023 17:16
@codecov Codecov
Copy link

codecov bot commented Nov 7, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ca0bc34) 39.58% compared to head (9d68719) 39.58%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #209   +/-   ##
=======================================
  Coverage   39.58%   39.58%           
=======================================
  Files           8        8           
  Lines         485      485           
=======================================
  Hits          192      192           
  Misses        272      272           
  Partials       21       21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

everettraven
everettraven reviewed Nov 8, 2023
View reviewed changes
docs/fetching-catalog-contents.md Show resolved Hide resolved
docs/fetching-catalog-contents.md Outdated Show resolved Hide resolved
docs/fetching-catalog-contents.md Outdated Show resolved Hide resolved
manifests/overlays/nginx-ingress/resources/nginx_ingress.yaml Outdated Show resolved Hide resolved
docs/fetching-catalog-contents.md Outdated Show resolved Hide resolved
@rashmigottipati
Add Ingress overlay to access Catalog contents outside of the cluster
d481d48 
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
@rashmigottipati
Address review feedback
1070e36 
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
@rashmigottipati
Address review feedback operator-framework#1
9434287 
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
@rashmigottipati
Address feedback operator-framework#2
9d68719 
Signed-off-by: Rashmi Gottipati <chowdary.grashmi@gmail.com>
@everettraven everettraven added this pull request to the merge queue Nov 10, 2023
Merged via the queue into operator-framework:main with commit 3dc8131 Nov 10, 2023
13 checks passed
@rashmigottipati rashmigottipati mentioned this pull request Nov 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everettraven everettraven everettraven approved these changes

@joelanford joelanford Awaiting requested review from joelanford

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure HTTP endpoints are accessible outside the cluster
3 participants
@rashmigottipati @joelanford @everettraven