-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure HTTP endpoints are accessible outside the cluster #118
Comments
This to me reads more as "write a kubectl plugin that connects to the service exposed by the controller to fetch and explore catalog content on cluster (get packages, get bundle should be sufficient to begin with). Unless there's a different way of solving this, we should probably modify the issue to be more explicit about what needs to be done. |
I was more so trying to convey that a user should be able to do a |
I see, we're talking Ingress here then. That's fine. |
What's proposed is likely not possible. The catalog's My assumption would be that we would document standard ways of exposing a
|
That's a fair assumption. I didn't think too far into if this approach is possible, but if the way to go about this is to document a standard way to access the service's endpoints using something like |
/assign @rashmigottipati |
Can close this as it's completed via #209 |
Thanks for the callout @rashmigottipati! Feel free to close directly when you see stuff like this. And also (you're probably aware, but I know its easy to forget) there's some GH syntax you can put in PR descriptions/comments that will get GH to do this for you automatically: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue |
@joelanford yeah, my bad, I forgot linking the GH issue in the PR description when I'd created it but added it after the PR was merged, so I don't think it was able to pick it up. 😅 And I was unable to close it directly as I don't see the "Close" button, I think it's because I am not a maintainer on this project. |
Ah! Well we should fix that! EDIT: Done! |
@joelanford thank you! |
Following #113 we should ensure that the necessary HTTP endpoints for getting catalog contents are accessible from outside the cluster. A user shouldn't have to perform any magic to
curl
the endpoint containing aCatalog
's contents.In essence, a user should be able to fetch the catalog content via the command line by:
kubectl get catalog {catalogName} -o yaml
to fetchCatalog
detailscurl {Catalog.Status.contentURL}
to fetch all the contents of theCatalog
The text was updated successfully, but these errors were encountered: