(server) Expose content URL on CR status #168

anik120 · 2023-09-14T14:15:03Z

closes #119

config/default/manager_auth_proxy_patch.yaml

codecov · 2023-09-14T14:29:08Z

Codecov Report

Patch coverage: 100.00% and project coverage change: -6.97% ⚠️

Comparison is base (21ba18e) 86.50% compared to head (93d07ac) 79.54%.

❗ Current head 93d07ac differs from pull request most recent head 4e31082. Consider uploading reports for the commit 4e31082 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
- Coverage   86.50%   79.54%   -6.97%     
==========================================
  Files           3        3              
  Lines         126      220      +94     
==========================================
+ Hits          109      175      +66     
- Misses         10       28      +18     
- Partials        7       17      +10

Files Changed	Coverage Δ
pkg/controllers/core/catalog_controller.go	`81.72% <100.00%> (-11.83%)`	⬇️
pkg/storage/localdir.go	`65.62% <100.00%> (+1.10%)`	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

everettraven

Since we have them now, could you also update the docs in https://github.com/operator-framework/catalogd/blob/main/docs/fetching-catalog-contents.md ?

config/default/manager_auth_proxy_patch.yaml

cmd/manager/main.go

pkg/controllers/core/catalog_controller.go

cmd/manager/main.go

api/core/v1alpha1/catalog_types.go

docs/fetching-catalog-contents.md

pkg/storage/localdir.go

closes operator-framework#119 Signed-off-by: Anik <anikbhattacharya93@gmail.com>

anik120 requested a review from a team as a code owner September 14, 2023 14:15

anik120 commented Sep 14, 2023

View reviewed changes

config/default/manager_auth_proxy_patch.yaml Outdated Show resolved Hide resolved

anik120 self-assigned this Sep 14, 2023

everettraven requested changes Sep 14, 2023

View reviewed changes

config/default/manager_auth_proxy_patch.yaml Outdated Show resolved Hide resolved

cmd/manager/main.go Outdated Show resolved Hide resolved

pkg/controllers/core/catalog_controller.go Outdated Show resolved Hide resolved

joelanford reviewed Sep 14, 2023

View reviewed changes

cmd/manager/main.go Outdated Show resolved Hide resolved

anik120 force-pushed the url-in-status branch from fd8cef2 to 263c078 Compare September 14, 2023 15:34