Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add go-apidiff action #151

Merged
merged 1 commit into from
Aug 30, 2023
Merged

add go-apidiff action #151

merged 1 commit into from
Aug 30, 2023

Conversation

joelanford
Copy link
Member

No description provided.

@joelanford
add go-apidiff action
a04c152 
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford joelanford requested a review from a team as a code owner August 29, 2023 19:27
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #151 (a04c152) into main (8aab690) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   79.61%   79.61%           
=======================================
  Files           2        2           
  Lines         157      157           
=======================================
  Hits          125      125           
  Misses         20       20           
  Partials       12       12

tmshort
tmshort approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2023
@awgreene
Copy link
Member

awgreene commented Aug 30, 2023 •
edited
Loading

Seems like it works based on it existing and passing in the list of GHA checks.
/approve

@joelanford joelanford added this pull request to the merge queue Aug 30, 2023
everettraven
everettraven approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to verify since I noticed it caused a bit of issues in other repos - this doesn't run as part of the merge queue checks correct?

Merged via the queue into operator-framework:main with commit cd2c38d Aug 30, 2023
9 checks passed
@joelanford joelanford deleted the add-go-apidiff branch August 30, 2023 16:26
@grokspawn
Copy link
Contributor

Just to verify since I noticed it caused a bit of issues in other repos - this doesn't run as part of the merge queue checks correct?

Confirm that it will not be run as merge queue, since the on event list includes only pull_request:

catalogd/.github/workflows/go-apidiff.yaml

Line 4 in cd2c38d

pull_request:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmshort tmshort tmshort approved these changes

@everettraven everettraven everettraven approved these changes

Assignees

@tmshort tmshort

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joelanford @awgreene @grokspawn @tmshort @everettraven