-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add default printer columns #174
add default printer columns #174
Conversation
314aba0
to
deecaf8
Compare
As a side effect related to this PR: Phase is deprecated in the API conventions. |
api/core/v1alpha1/catalog_types.go
Outdated
@@ -47,6 +47,8 @@ const ( | |||
//+kubebuilder:object:root=true | |||
//+kubebuilder:resource:scope=Cluster | |||
//+kubebuilder:subresource:status | |||
//+kubebuilder:printcolumn:name="Catalog Phase",type=string,JSONPath=`.status.phase` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I think just "Phase" is probably fine here
Signed-off-by: kevinrizza <krizza@redhat.com>
deecaf8
to
fb6bfe9
Compare
I updated the printer header from |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #174 +/- ##
=======================================
Coverage 87.02% 87.02%
=======================================
Files 3 3
Lines 131 131
=======================================
Hits 114 114
Misses 10 10
Partials 7 7 ☔ View full report in Codecov by Sentry. |
Thanks @kevinrizza! |
Add printer columns to catalog API. Adds Phase as well as Age printer columns
Resolves #172