(cleanup) Kustomization

[anik120]

Closes #155, #160

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7f903c6) 87.02% compared to head (32bd184) 87.02%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #183   +/-   ##
=======================================
  Coverage   87.02%   87.02%           
=======================================
  Files           3        3           
  Lines         131      131           
=======================================
  Hits          114      114           
  Misses         10       10           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[everettraven]

Looks like there is also a prometheus directory that is unused. We do expose metrics that can be monitored via prometheus, but it seems like we haven't ever shipped the manifests with the ServiceMonitor definition. Should we remove this and instead add some documentation with an example ServiceMonitor that can be applied for grabbing metrics?

[anik120]

I think that's a good idea +1. We should probably do the removal and subsequent documentation in a separate, single PR though.

[joelanford]

I would vote to remove it now if it is extraneous. We can add it back (or examples) if/when someone asks for it.

[anik120]

Done. Removed the prometheus folder.

[joelanford]

@anik120 Can you also remove or edit some or all of the app.kubernetes.io-prefixed labels? The values don't seem to quite align to the docs.

I'd reduce to this for now:

    app.kubernetes.io/name: catalogd
    app.kubernetes.io/part-of: olm

[anik120]

@anik120 Can you also remove or edit some or all of the app.kubernetes.io-prefixed labels? The values don't seem to quite align to the docs.

I'd reduce to this for now:

    app.kubernetes.io/name: catalogd
    app.kubernetes.io/part-of: olm

@joelanford done