(feature): add skip-tls-verify option for image sources

[everettraven]

Description

• Adds an skipTLSVerify field to the image source type to allow users to specify that a catalog is being sourced from an insecure registry. When setting skipTLSVerify: true, catalogd will skip TLS verification when pulling the catalog image.
• Removes trusted certificate injection for e2e tests

Motivation

• Provide a method to disable TLS verification to simplify local testing of catalog images

[codecov]

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e078853) 39.70% compared to head (d798110) 40.04%.

❗ Current head d798110 differs from pull request most recent head 6e9a118. Consider uploading reports for the commit 6e9a118 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   39.70%   40.04%   +0.33%     
==========================================
  Files           8        8              
  Lines         471      477       +6     
==========================================
+ Hits          187      191       +4     
- Misses        265      266       +1     
- Partials       19       20       +1     

Files	Coverage Δ
api/core/v1alpha1/catalog_types.go	100.00% <ø> (ø)
internal/source/image_registry_client.go	67.04% <66.66%> (-0.03%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[anik120]

What if we used an environment variable instead? We'll read the environment variable from the binary and set a skipTLSInsecureSkipVerify field for ImageRegistry accordingly.

[everettraven]

What if we used an environment variable instead? We'll read the environment variable from the binary and set a skipTLSInsecureSkipVerify field for ImageRegistry accordingly.

This would disable TLS verification for all image registries which I'm not sure is desirable. The current state of this PR gives the flexibility to disable TLS verification on a per catalog basis. This would also require modification to the catalogd controller-manager deployment which the current PR does not require. I'm happy to continue this discussion further but, IMO, the current state of the PR is more desirable than a global disable TLS verification option.

[anik120]

Okay I'm good with this PR I'll leave it upto @joelanford to hit the merge button