🐛 attempt to remove cache entry if unpack fails #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
==========================================
- Coverage 40.04% 39.58% -0.46%
==========================================
Files 8 8
Lines 477 485 +8
==========================================
+ Hits 191 192 +1
- Misses 266 272 +6
- Partials 20 21 +1
☔ View full report in Codecov by Sentry. |
everettraven
commented
Nov 2, 2023
ncdc
reviewed
Nov 3, 2023
and add a new test case that ensures if the required label is missing from the image, thus failing image unpacking, an error is consistently returned fixes operator-framework#206 Signed-off-by: Bryce Palmer <everettraven@gmail.com>
everettraven
force-pushed
the
bugfix/gh206
branch
from
ca76992
to
94d487b
Compare
everettraven
commented
Nov 3, 2023
ncdc
approved these changes
Nov 3, 2023
Merged
via the queue into
operator-framework:main
with commit Nov 3, 2023
a0e2dee
11 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ImageRegistry.Unpack()implementation to attempt to remove the cache entry ifunpackImage()failsMotivation
Unpacked == Truewhen really failing due to catalog image missing labeloperators.operatorframework.io.index.configs.v1#206