Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Remove cert-manager from release note install process #215

Merged
merged 1 commit into from
Nov 22, 2023
Merged

🌱 Remove cert-manager from release note install process #215

merged 1 commit into from
Nov 22, 2023

Conversation

everettraven
Copy link
Collaborator

Description:

  • Removes the cert-manager references from the installation guide on the release notes published by goreleaser. catalogd has not depended on cert-manager being installed for quite some time.

Motivation

  • Prevent users from installing unnecessary stuff if they only want to install catalogd. Also prevents the idea that catalogd has some dependency on cert-manager.

@everettraven
Remove cert-manager from release note install process
737dcef 
as cert-manager has not been a requirement for installing
catalogd for quite some time.

Signed-off-by: Bryce Palmer <everettraven@gmail.com>
@everettraven everettraven requested a review from a team as a code owner November 21, 2023 19:47
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a7cd270) 39.58% compared to head (737dcef) 39.58%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #215   +/-   ##
=======================================
  Coverage   39.58%   39.58%           
=======================================
  Files           8        8           
  Lines         485      485           
=======================================
  Hits          192      192           
  Misses        272      272           
  Partials       21       21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevekuznetsov stevekuznetsov added this pull request to the merge queue Nov 22, 2023
Merged via the queue into operator-framework:main with commit 404dc58 Nov 22, 2023
12 checks passed
@grokspawn grokspawn added this to the v0.11.0 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevekuznetsov stevekuznetsov stevekuznetsov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@everettraven @stevekuznetsov @grokspawn