Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 bump the catalogserver write timeout to 5 minutes #223

Merged

Conversation

everettraven
Copy link
Collaborator

to allow for fully writing large catalogs contents in the response

@everettraven everettraven requested a review from a team as a code owner January 9, 2024 21:41
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (1b0517f) 39.58% compared to head (1c10eaf) 39.58%.
Report is 3 commits behind head on main.

Files Patch % Lines
cmd/manager/main.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #223   +/-   ##
=======================================
  Coverage   39.58%   39.58%           
=======================================
  Files           8        8           
  Lines         485      485           
=======================================
  Hits          192      192           
  Misses        272      272           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/manager/main.go Outdated Show resolved Hide resolved
ncdc
ncdc previously approved these changes Jan 9, 2024
@ncdc ncdc enabled auto-merge January 9, 2024 21:50
@ncdc ncdc added this pull request to the merge queue Jan 9, 2024
@everettraven everettraven removed this pull request from the merge queue due to a manual request Jan 9, 2024
@everettraven
Copy link
Collaborator Author

Removed from merge queue as there is some discussion around whether or not 1 minute is enough

to allow for fully writing large catalogs contents
in the response

Signed-off-by: everettraven <everettraven@gmail.com>
@everettraven everettraven changed the title 🐛 bump the catalogserver write timeout to 1 minute 🐛 bump the catalogserver write timeout to 5 minutes Jan 10, 2024
@joelanford joelanford added this pull request to the merge queue Jan 10, 2024
Merged via the queue into operator-framework:main with commit 5c95b4a Jan 10, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants