Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 add validation for pollInterval duration units #225

Merged

Conversation

everettraven
Copy link
Collaborator

fixes #224

Signed-off-by: everettraven <everettraven@gmail.com>
@everettraven everettraven requested a review from a team as a code owner January 10, 2024 22:11
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b0517f) 39.58% compared to head (38480e8) 39.58%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #225   +/-   ##
=======================================
  Coverage   39.58%   39.58%           
=======================================
  Files           8        8           
  Lines         485      485           
=======================================
  Hits          192      192           
  Misses        272      272           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. This makes me think we should have some tests for the CRD schema.

@everettraven
Copy link
Collaborator Author

Good catch.

I can't take credit for this because OpenShift QE reported this, I just filed the upstream issue and made the fix 😄

This makes me think we should have some tests for the CRD schema.

Agreed. Created #226 for tracking this

@everettraven everettraven added this pull request to the merge queue Jan 11, 2024
Merged via the queue into operator-framework:main with commit 4d2ea6a Jan 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add validation to ensure the pollInterval field only accepts the correct units
2 participants