🌱 make golangci-lint config consistent across repos #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #255 +/- ##
=======================================
Coverage 48.84% 48.84%
=======================================
Files 8 8
Lines 434 434
=======================================
Hits 212 212
Misses 201 201
Partials 21 21 ☔ View full report in Codecov by Sentry. |
tmshort
reviewed
Apr 25, 2024
| @@ -35,11 +35,11 @@ $(GINKGO): $(BINGO_DIR)/ginkgo.mod | |||
| @echo "(re)installing $(GOBIN)/ginkgo-v2.12.0" | |||
| @cd $(BINGO_DIR) && GOWORK=off $(GO) build -mod=mod -modfile=ginkgo.mod -o=$(GOBIN)/ginkgo-v2.12.0 "github.com/onsi/ginkgo/v2/ginkgo" | |||
|
|
|||
| GOLANGCI_LINT := $(GOBIN)/golangci-lint-v1.53.3 | |||
There was a problem hiding this comment.
Why do I really want these version numbers to be variables?
tmshort
reviewed
Apr 25, 2024
| # If you are making a change, please make it in ALL | ||
| # of the above repositories! | ||
| # | ||
| # TODO: Find a way to have a shared golangci config. |
joelanford
commented
Apr 25, 2024
cmd/manager/main.go
Outdated
Comment on lines
42
to
40
| //+kubebuilder:scaffold:imports | ||
| "github.com/operator-framework/catalogd/api/core/v1alpha1" |
There was a problem hiding this comment.
This seems bad. I think I'll just delete this line.
joelanford
commented
Apr 25, 2024
cmd/manager/main.go
Outdated
Comment on lines
32
to
33
| // Import all Kubernetes client auth plugins (e.g. Azure, GCP, OIDC, etc.) | ||
| // to ensure that exec-entrypoint and run can make use of them. |
There was a problem hiding this comment.
I'm going to delete this line as well. IIRC, it is scaffolded with Kubebuilder/Operator SDK. It is meant to go with the _ "k8s.io/client-go/plugin/pkg/client/auth" import, but it seems to always get jumbled with import formaters run.
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
joelanford
force-pushed
the
consistent-golangci-lint-config
branch
from
00c819f
to
623470d
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.