Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Makefile: fix issues with repeated evaluations #267

Merged
merged 1 commit into from
May 14, 2024

Conversation

joelanford
Copy link
Member

@joelanford joelanford commented May 10, 2024

Closes #261

@joelanford joelanford requested a review from a team as a code owner May 10, 2024 13:54
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.84%. Comparing base (cf384e4) to head (2dc0d96).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #267   +/-   ##
=======================================
  Coverage   48.84%   48.84%           
=======================================
  Files           8        8           
  Lines         434      434           
=======================================
  Hits          212      212           
  Misses        201      201           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelanford joelanford force-pushed the improve-makefile branch 8 times, most recently from c35eba9 to c552a7f Compare May 14, 2024 21:00
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 14, 2024
@varshaprasad96 varshaprasad96 added this pull request to the merge queue May 14, 2024
Merged via the queue into operator-framework:main with commit b68cda4 May 14, 2024
11 checks passed
@joelanford joelanford deleted the improve-makefile branch May 15, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Makefile to avoid unnecessarily shelling out multiple times for the same variables
3 participants