Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Rename Catalog to ClusterCatalog #268

Merged
merged 1 commit into from
May 15, 2024
Merged

⚠️ Rename Catalog to ClusterCatalog #268

merged 1 commit into from
May 15, 2024

Conversation

everettraven
Copy link
Collaborator

No description provided.

@everettraven everettraven requested a review from a team as a code owner May 14, 2024 15:46
everettraven
everettraven commented May 14, 2024
View reviewed changes
api/core/v1alpha1/clustercatalog_types.go
// +kubebuilder:validation:XValidation:rule="!has(self.source.image.pollInterval) || (self.source.image.ref.find('@sha256:') == \"\")",message="cannot specify PollInterval while using digest-based image"
type CatalogSpec struct {
type ClusterCatalogSpec struct {
// Source is the source of a Catalog that contains Operators' metadata in the FBC format
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for reviewers: I did not modify the "Catalog" reference here because I am interpreting it as the general umbrella term "Catalog" rather than an explicit reference to the on-cluster API. Happy to update this if necessary.

@codecov Codecov
Copy link

codecov bot commented May 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 27.08333% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 48.84%. Comparing base (cf384e4) to head (b7087fa).
Report is 1 commits behind head on main.

❗ Current head b7087fa differs from pull request most recent head a9b78da. Consider uploading reports for the commit a9b78da to get more accurate results

Files Patch % Lines
api/core/v1alpha1/zz_generated.deepcopy.go 0.00% 27 Missing ⚠️
pkg/controllers/core/clustercatalog_controller.go 61.53% 5 Missing ⚠️
internal/source/unpacker.go 0.00% 2 Missing ⚠️
internal/garbagecollection/garbage_collector.go 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #268   +/-   ##
=======================================
  Coverage   48.84%   48.84%           
=======================================
  Files           8        8           
  Lines         434      434           
=======================================
  Hits          212      212           
  Misses        201      201           
  Partials       21       21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

joelanford
joelanford reviewed May 14, 2024
View reviewed changes
config/samples/core_v1alpha1_catalog.yaml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to config/samples/core_v1alpha1_clustercatalog.yaml?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be done in the latest push

@everettraven
rename Catalog to ClusterCatalog
a9b78da 
Signed-off-by: everettraven <everettraven@gmail.com>
@joelanford joelanford enabled auto-merge May 15, 2024 13:57
@joelanford joelanford added this pull request to the merge queue May 15, 2024
Merged via the queue into operator-framework:main with commit 4f1219c May 15, 2024
9 of 10 checks passed
OchiengEd added a commit to OchiengEd/operator-controller that referenced this pull request Jun 13, 2024
@OchiengEd
fix: Rename Catalog to ClusterCatalog object
5479625 
Rename Catalog to ClusterCatalog to conform with the changes in catalogd. See [issue operator-framework#268](operator-framework/catalogd/pull/268)

Signed-off-by: Edmund Ochieng <ochienged@gmail.com>
@OchiengEd OchiengEd mentioned this pull request Jun 13, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@everettraven @joelanford