Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Bump k8s deps to 0.30.0 and go 1.22 #269

Merged
merged 2 commits into from
May 16, 2024
Merged

✨ Bump k8s deps to 0.30.0 and go 1.22 #269

merged 2 commits into from
May 16, 2024

Conversation

everettraven
Copy link
Collaborator

No description provided.

@everettraven everettraven requested a review from a team as a code owner May 14, 2024 19:00
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2024
everettraven
everettraven commented May 14, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
everettraven
everettraven commented May 14, 2024
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented May 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.12%. Comparing base (4f1219c) to head (3d9532f).

❗ Current head 3d9532f differs from pull request most recent head 13504da

Please upload reports for the commit 13504da to get more accurate results.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #269       +/-   ##
===========================================
- Coverage   48.84%   33.12%   -15.73%     
===========================================
  Files           8       15        +7     
  Lines         434      646      +212     
===========================================
+ Hits          212      214        +2     
- Misses        201      411      +210     
  Partials       21       21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@everettraven everettraven marked this pull request as draft May 14, 2024 20:23
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2024
@everettraven
bump to go 1.22 and k8s 0.30.0
d5d2662 
Signed-off-by: everettraven <everettraven@gmail.com>
@everettraven everettraven marked this pull request as ready for review May 15, 2024 20:33
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 15, 2024
@everettraven
bump o-reg to tag
13504da 
Signed-off-by: everettraven <everettraven@gmail.com>
everettraven
everettraven commented May 16, 2024
View reviewed changes
.bingo/kind.mod
@@ -2,4 +2,4 @@ module _ // Auto generated by https://github.com/bwplotka/bingo. DO NOT EDIT

go 1.20
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that this line didn't update automatically...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like kind is on go 1.17 still: https://github.com/kubernetes-sigs/kind/blob/a471512eac459c6ab23600b3825b685bc069d094/go.mod#L11

Probably didn't update because it doesn't need to, but I'm a novice at the nuances of go package management

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I want to say there was some bingo faking out go.mod stuff that went on, and bingo hasn't yet been updated for 1.21+, which implies no toolchain management.
So it's inconsistent, and it flaps based on submittor's runtime environment, which is a distraction.

rashmigottipati
rashmigottipati approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2024
@everettraven everettraven added this pull request to the merge queue May 16, 2024
Merged via the queue into operator-framework:main with commit fa4a29b May 16, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grokspawn grokspawn grokspawn approved these changes

@rashmigottipati rashmigottipati rashmigottipati approved these changes

Assignees

@rashmigottipati rashmigottipati

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@everettraven @rashmigottipati @grokspawn @openshift-merge-robot