Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠ Change default namespace to olmv1-system #283

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

trgeiger
Copy link
Contributor

@trgeiger trgeiger commented Jun 11, 2024

Wasn't really sure if we considered this a major or minor change.

This changes the default namespace for Catalogd from catalogd-system to olmv1-system as part of the effort to move all OLMv1 components to the same namespace.

@trgeiger trgeiger requested a review from a team as a code owner June 11, 2024 19:43
everettraven
everettraven previously approved these changes Jun 11, 2024
auto-merge was automatically disabled June 11, 2024 19:46

Head branch was pushed to by a user without write access

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.12%. Comparing base (fae2442) to head (5a295a1).

Files Patch % Lines
cmd/manager/main.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #283   +/-   ##
=======================================
  Coverage   33.12%   33.12%           
=======================================
  Files          15       15           
  Lines         646      646           
=======================================
  Hits          214      214           
  Misses        411      411           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@everettraven everettraven added this pull request to the merge queue Jun 11, 2024
Merged via the queue into operator-framework:main with commit cd15788 Jun 11, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants