Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 adding gzip content support #293

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

grokspawn
Copy link
Contributor

@grokspawn grokspawn commented Jun 27, 2024

This is an inexpensive-to-implement approach which takes no action (and incurs no cost) unless:

  1. the served content exceeds (a default) size of 1400 bytes; and
  2. the client indicates support for compressed streaming via request header "Accept-Encoding" set to "gzip"

It's possible that we may decide later to trade CPU load for disk space, once we get an opportunity to generate some benchmarks with this approach.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.12%. Comparing base (c0ed3fa) to head (7443661).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #293   +/-   ##
=======================================
  Coverage   33.12%   33.12%           
=======================================
  Files          15       15           
  Lines         646      646           
=======================================
  Hits          214      214           
  Misses        411      411           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grokspawn grokspawn marked this pull request as ready for review June 28, 2024 20:01
@grokspawn grokspawn requested a review from a team as a code owner June 28, 2024 20:01
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 28, 2024
@grokspawn grokspawn force-pushed the gzip-content-support branch 2 times, most recently from 430825d to 82a070c Compare June 28, 2024 20:38
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
@grokspawn
Copy link
Contributor Author

Found a more concise (and general) test approach, plus realized I'd omitted the status == 200 test accidentally. 🐑-ish

Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 28, 2024
@tmshort tmshort added this pull request to the merge queue Jun 28, 2024
Merged via the queue into operator-framework:main with commit d1f1462 Jun 28, 2024
12 checks passed
@grokspawn grokspawn deleted the gzip-content-support branch June 28, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants