Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Remove the second installation of cert-manager #300

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Jul 9, 2024

It looks like this is unnecessary

@m1kola m1kola requested a review from a team as a code owner July 9, 2024 09:14
@m1kola m1kola changed the title 🌱 Remove the second installation of cert-manager 🌱 Remove the second installation of cert-manager & bump ginkgo CLI in bingo Jul 9, 2024
@m1kola m1kola changed the title 🌱 Remove the second installation of cert-manager & bump ginkgo CLI in bingo 🌱 Remove the second installation of cert-manager Jul 9, 2024
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola m1kola force-pushed the remove-second-cert-manager-installation branch from 1168f30 to 64e7759 Compare July 9, 2024 09:15
@m1kola m1kola requested a review from ankitathomas July 9, 2024 09:17
@m1kola m1kola mentioned this pull request Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.53%. Comparing base (7c0bcb4) to head (64e7759).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage   33.53%   33.53%           
=======================================
  Files          15       15           
  Lines         656      656           
=======================================
  Hits          220      220           
  Misses        413      413           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@everettraven everettraven added this pull request to the merge queue Jul 9, 2024
Merged via the queue into operator-framework:main with commit f2dfb2a Jul 9, 2024
11 checks passed
@m1kola m1kola deleted the remove-second-cert-manager-installation branch July 10, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants