add version information #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-merge-robot
added
the
needs-rebase
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
everettraven
force-pushed
the
releasing/add-versions
branch
from
6403277
to
367431c
Compare
openshift-merge-robot
removed
the
needs-rebase
everettraven
removed
the
do-not-merge/work-in-progress
joelanford
reviewed
Apr 18, 2023
joelanford
reviewed
Apr 18, 2023
joelanford
reviewed
Apr 18, 2023
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
joelanford
reviewed
Apr 20, 2023
joelanford
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds an internal version package with:
Updates the Makefile to set the necessary version flags when building
Adds a
--versionflag to the controller managerUpdates goreleaser to set the version flags when building the controller and apiserver
In a follow up, we will have to configure the version information for the apiserver. The
apiserver-runtimepackage that we are currently using to build the apiserver hardcodes version information that overrides any of the information we include. I left a TODO comment to reflect this. A solution is to update theapiserver-runtimetooling OR create or own implementation that we use to set the version info. This can likely be addressed as part of Remove Catalogmetadata CRD and serve CatalogMetadata with aggregated apiserver #39 when we configure the apiserver to work properly.Motivation: