Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): export the CERT_MGR_VERSION env var for releasing #47

Merged

Conversation

everettraven
Copy link
Collaborator

Description

  • Update the Makefile to export the CERT_MGR_VERSION environment variable when releasing

Motivation

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven
Copy link
Collaborator Author

/cherry-pick release-v0.1

@openshift-cherrypick-robot

@everettraven: once the present PR merges, I will cherry-pick it on top of release-v0.1 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v0.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@dtfranz dtfranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but also wondering what the reason is for not exporting them in one place up above like we have here?

Edit: I don't have write access for approval 😢

@everettraven
Copy link
Collaborator Author

but also wondering what the reason is for not exporting them in one place up above like we have here?

No particular reason - I think we put them where they are since they are only used for the release process so at the time it made sense to keep them near the release target. We can move them in a follow-up if we want to be more consistent with what operator-controller is doing.

@openshift-cherrypick-robot

@everettraven: new pull request created: #48

In response to this:

/cherry-pick release-v0.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants