Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

respect cluster image pull configurations #54

Merged
merged 4 commits into from
Apr 25, 2023
Merged

respect cluster image pull configurations #54

merged 4 commits into from
Apr 25, 2023

Conversation

everettraven
Copy link
Collaborator

Description

  • When creating an unpack job use init containers to pull the catalog image, populate a volume with fbc configs, and use the opm image to render the configs from the volume. This ensures we are respecting the cluster pull configurations by not pulling an image within the unpack pod.

Motivation

@everettraven
respect cluster image pull configurations
97997f0 
when creating an unpack job by using init containers to pull the catalog image
, populate a volume with fbc configs, and use the opm image to render the configs
from the volume

fixes operator-framework#21

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven
flip job containers around
93efc1e 
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven everettraven mentioned this pull request Apr 24, 2023
Closed
@everettraven
use filepath.Join() instead of fmt.Sprintf()
7a0e413 
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven
restrict config directory to /configs/
6108501 
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
joelanford
joelanford approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@everettraven everettraven merged commit 8ec4467 into operator-framework:main Apr 25, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unpack job does not honor cluster pull configuration
2 participants
@everettraven @joelanford