API cleanup #58
Merged
API cleanup #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelanford
force-pushed
the
api-refactor
branch
from
1487175
to
9ed4803
Compare
grokspawn
reviewed
Apr 28, 2023
| @@ -18,7 +17,7 @@ spec: | |||
| - name: v1beta1 | |||
| schema: | |||
| openAPIV3Schema: | |||
| description: Package | |||
| description: Package is the Schema for the packages API | |||
There was a problem hiding this comment.
Can we use apostrophe for possessives in the spec?
Suggested change
| description: Package is the Schema for the packages API | |
| description: Package is the Schema for the package's API |
There was a problem hiding this comment.
This is meant to be plural (e.g. the resource name).
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for more drastic changes to our APIs, I've gone through and cleaned up stuff that is not currently used. This should make it easier to review future substantive changes to the APIs.
This PR also changes the
BundleMetadataproperty type to useruntime.RawExtensioninstead of[]byte, which is necessary to correctly serialize/deserizalize property values. (discussed here)