Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CatalogSource to Catalog #60

Merged
merged 7 commits into from
May 15, 2023
Merged

Rename CatalogSource to Catalog #60

merged 7 commits into from
May 15, 2023

Conversation

everettraven
Copy link
Collaborator

Description

  • Rename the CatalogSource CRD to Catalog

Motivation:

@everettraven
rename CatalogSource to Catalog
0351d91 
Signed-off-by: Bryce Palmer <everettraven@gmail.com>
@everettraven
make generate
7e6cc68 
Signed-off-by: Bryce Palmer <everettraven@gmail.com>
@everettraven
fix manifests and rename file
fb1026d 
Signed-off-by: Bryce Palmer <everettraven@gmail.com>
@everettraven
update sample
728b82c 
Signed-off-by: Bryce Palmer <everettraven@gmail.com>
@everettraven
update sample
1c0b076 
Signed-off-by: Bryce Palmer <everettraven@gmail.com>
joelanford
joelanford approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2023
@everettraven
Copy link
Collaborator Author

There are a couple changes I made locally but still need to push up to replace a couple other references of CatalogSource with Catalog

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2023
@everettraven
catalogsource --> catalog
e2e4b25 
Signed-off-by: Bryce Palmer <everettraven@gmail.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 9, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 9, 2023

New changes are detected. LGTM label has been removed.

@everettraven
Copy link
Collaborator Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2023
@grokspawn
Copy link
Contributor

grokspawn commented May 9, 2023 •
edited
Loading

Also

catalogd/pprof/README.md

Line 3 in 8427196

This folder contains some profiles that can be read using [pprof](https://github.com/google/pprof) to show how the core kubernetes apiserver and the custom catalogd apiserver CPU & Memory utilization is affected by the creation and reconciliation of the sample `CatalogSource` CR found at `../config/samples/catalogsource.yaml`.
(and others in that file)

/hold
req-for-changes

@grokspawn grokspawn added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2023
@everettraven
update pprof readme references
654eb8f 
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@grokspawn
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2023
@grokspawn
Copy link
Contributor

Thanks Bryce!

@grokspawn grokspawn merged commit 70ef727 into operator-framework:main May 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelanford joelanford joelanford approved these changes

Assignees

@joelanford joelanford

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename CatalogSource to OperatorCatalog
3 participants
@everettraven @grokspawn @joelanford