Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat): (testing): Add extensible unpacking interface + controller tests #65

Merged
merged 11 commits into from
May 24, 2023
Merged

(feat): (testing): Add extensible unpacking interface + controller tests #65

merged 11 commits into from
May 24, 2023

Commits on May 16, 2023

  1. add unpacker interface and image source type from operator-framework#59 

    Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
    @everettraven
    everettraven committed May 16, 2023
    Configuration menu
    Copy the full SHA
    fdd0f2c View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. add tests and some minor cleanup 

    Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
    @everettraven
    everettraven committed May 17, 2023
    Configuration menu
    Copy the full SHA
    00490ce View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. remove unnecessary function as per review comments 

    Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
    @everettraven
    everettraven committed May 18, 2023
    Configuration menu
    Copy the full SHA
    8139725 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. address review comments 

    Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
    @everettraven
    everettraven committed May 19, 2023
    Configuration menu
    Copy the full SHA
    a8dd3c9 View commit details
    Browse the repository at this point in the history

  2. commit forgotten files 

    Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
    @everettraven
    everettraven committed May 19, 2023
    Configuration menu
    Copy the full SHA
    dd71148 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. add AfterEach() blocks 

    Signed-off-by: Bryce Palmer <everettraven@gmail.com>
    @everettraven
    everettraven committed May 22, 2023
    Configuration menu
    Copy the full SHA
    66586db View commit details
    Browse the repository at this point in the history

  2. refactor the happy path test to be multiple smaller tests 

    Signed-off-by: Bryce Palmer <everettraven@gmail.com>
    @everettraven
    everettraven committed May 22, 2023
    Configuration menu
    Copy the full SHA
    cdc5d15 View commit details
    Browse the repository at this point in the history

  3. more consistent image source field naming 

    Signed-off-by: Bryce Palmer <everettraven@gmail.com>
    @everettraven
    everettraven committed May 22, 2023
    Configuration menu
    Copy the full SHA
    d0fe3b3 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. address review comments 

    Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
    @everettraven
    everettraven committed May 23, 2023
    Configuration menu
    Copy the full SHA
    fbf0653 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. add comment above template variables 

    Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
    @everettraven
    everettraven committed May 24, 2023
    Configuration menu
    Copy the full SHA
    2868d7f View commit details
    Browse the repository at this point in the history

  2. remove line numbers from comment 

    Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
    @everettraven
    everettraven committed May 24, 2023
    Configuration menu
    Copy the full SHA
    79d2334 View commit details
    Browse the repository at this point in the history