Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile and goreleaser config for more generic/consistent builds #71

Merged
merged 1 commit into from
May 24, 2023

Conversation

joelanford
Copy link
Member

@joelanford joelanford commented May 23, 2023

Cleaning up unused files and bringing the catalogd build configuration more in line with operator-controller and rukpak.

Notable changes:

  • Produce a single container image rather than one for each binary
  • Use goreleaser to build the binaries for both local builds and release builds to ensure consistent build environment variables and flags.
  • De-duplicate lines for setting and exporting environment variables.
  • make run now installs catalogd into a fresh kind cluster. This aligns with operator-controller and rukpak. The former make run (which ran the manager binary locally) command is removed because it won't easily scale to handle projects that require multiple running binaries (e.g. a webhook, a controller, an apiserver, etc)
  • Remove references and files related to the now non-existent apiserver.

Primary motivation is to make sure that the downstreaming process for OLMv1 repositories is consistent, that the automation is consistent, and that we can re-use as much as possible from upstream when building downstream.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 23, 2023
@joelanford joelanford force-pushed the more-generic-build-setup branch 2 times, most recently from 5fd2795 to 3362ba4 Compare May 23, 2023 19:39
@joelanford joelanford changed the title WIP: update Makefile and goreleaser config for more generic builds WIP: update Makefile and goreleaser config for more generic/consistent builds May 23, 2023
@joelanford joelanford changed the title WIP: update Makefile and goreleaser config for more generic/consistent builds Update Makefile and goreleaser config for more generic/consistent builds May 23, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 23, 2023
Copy link
Collaborator

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions/comments but overall this looks good to me

/lgtm

.goreleaser.yml Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 23, 2023

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 23, 2023
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@joelanford joelanford merged commit 7e57480 into main May 24, 2023
3 checks passed
@joelanford joelanford deleted the more-generic-build-setup branch May 24, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants