Make sure setup-envtest works in CI #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelanford
reviewed
May 25, 2023
Makefile
Outdated
Comment on lines
12
to
15
| # Some CI setups may not have XDG_DATA_HOME or HOME set. One of these is required for setup-envtest to work correctly. | ||
| export XDG_DATA_HOME ?= /tmp/.local/share |
There was a problem hiding this comment.
Does setup-envtest prefer HOME over XDG_DATA_HOME if both are set?
There was a problem hiding this comment.
Signed-off-by: Andy Goldstein <andy.goldstein@redhat.com>
joelanford
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.