Add feature gates infrastructure #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
joelanford
reviewed
Jun 8, 2023
joelanford
reviewed
Jun 8, 2023
ncdc
reviewed
Jun 8, 2023
ncdc
reviewed
Jun 8, 2023
ncdc
reviewed
Jun 8, 2023
cmd/manager/main.go
Outdated
| opts.BindFlags(flagSet) | ||
|
|
||
| // set up feature gate flags. This has to use a pflag flagset | ||
| pFlagSet := pflag.NewFlagSet("featuregate-flagset", pflag.ExitOnError) |
There was a problem hiding this comment.
I'm not sure I would put the feature gates in a separate flagset.
There was a problem hiding this comment.
Tried to address this in 353165a - let me know if that is insufficient
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
joelanford
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
featuresthat contains the infrastructure required for adding feature gates to catalogd--feature-gateflagMotivation