#81 Updated README #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
michaelryanpeter
force-pushed
the
#81-update-readme
branch
from
1088e69
to
b174d8d
Compare
everettraven
reviewed
Jun 9, 2023
michaelryanpeter
force-pushed
the
#81-update-readme
branch
4 times, most recently
from
7a0a5f8
to
1be4af0
Compare
anik120
requested changes
Jun 13, 2023
|
@anik120 Would you PTAL at the updates and let know if they address your concerns? |
anik120
reviewed
Jun 22, 2023
|
Also the DCO check is failing (if you click on |
michaelryanpeter
force-pushed
the
#81-update-readme
branch
from
bef874d
to
18b6c37
Compare
|
New changes are detected. LGTM label has been removed. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
michaelryanpeter
force-pushed
the
#81-update-readme
branch
from
18b6c37
to
3cfb851
Compare
|
@anik120 and @everettraven: I got kind working, added example outputs, and squashed and signed my commit. Do I need to request more reviews in Slack? |
michaelryanpeter
force-pushed
the
#81-update-readme
branch
2 times, most recently
from
e8b1577
to
ef5090d
Compare
@michaelryanpeter if you want some extra eyes it doesn't hurt to throw it in the #olm-dev channel in the Kubernetes slack |
anik120
approved these changes
Jun 26, 2023
Issue: operator-framework#81 Signed-off-by: Michael Ryan Peter <mipeter@redhat.com> Fix output examples Signed-off-by: Michael Ryan Peter <mipeter@redhat.com>
michaelryanpeter
force-pushed
the
#81-update-readme
branch
from
227a130
to
002c295
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #81
Update the catalogd README to reflect the current state of the project and its place in the OLM v1 project.