Replace separator in NotSatisfiable error

Use new line instead of comma as a separator. Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
operator-framework · Nov 13, 2023 · ddaf504 · ddaf504
1 parent 0a012d2
commit ddaf504
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/internal/solver/solve_test.go b/internal/solver/solve_test.go
@@ -65,7 +65,7 @@ func TestNotSatisfiableError(t *testing.T) {
 					Constraint: constraint.Mandatory(),
 				},
 			},
-			String: fmt.Sprintf("constraints not satisfiable: %s",
+			String: fmt.Sprintf("constraints not satisfiable:\n%s",
 				constraint.Mandatory().String("a")),
 		},
 		{
@@ -80,7 +80,7 @@ func TestNotSatisfiableError(t *testing.T) {
 					Constraint: constraint.Prohibited(),
 				},
 			},
-			String: fmt.Sprintf("constraints not satisfiable: %s, %s",
+			String: fmt.Sprintf("constraints not satisfiable:\n%s\n%s",
 				constraint.Mandatory().String("a"), constraint.Prohibited().String("b")),
 		},
 	} {

diff --git a/pkg/deppy/api.go b/pkg/deppy/api.go
@@ -21,7 +21,7 @@ func (e NotSatisfiable) Error() string {
 	for i, a := range e {
 		s[i] = a.String()
 	}
-	return fmt.Sprintf("%s: %s", msg, strings.Join(s, ", "))
+	return fmt.Sprintf("%s:\n%s", msg, strings.Join(s, "\n"))
 }
 
 // Identifier values uniquely identify particular Variables within