Adds ginkgolinter
#106
Merged
Adds ginkgolinter
#106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
m1kola
force-pushed
the
adds_ginkgolinter
branch
from
3021e5d
to
d708e12
Compare
Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
m1kola
force-pushed
the
adds_ginkgolinter
branch
from
d708e12
to
bfc8fff
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
ncdc
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linter which checks for common ginkgo issues like wrong error assertions (
Expect(err).To(BeNil())instead ofExpect(err).NotTo(HaveOccurred())), etc.It also identifies
Expectcalls without a matcher.See operator-framework/rukpak#637 for examples where it was super useful.