Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codecov-action params #189

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Jun 20, 2024

  • functionalities param is no longer exist. It was used to enable file fixes to ignore common lines from coverage. This feature is now seems to be on by default.

  • Adding disable_search because we do not need for the codecov action to search for coverage files: we explicitly provide files.

* `functionalities` param is no longer exist.
  It was used to enable file fixes to ignore common lines from coverage.
  This feature is now seems to be on by default.

* Adding `disable_search` because we do not need for the codecov action
  to search for coverage files: we explicitly provide files.

Signed-off-by: Mikalai Radchuk <mradchuk@redhat.com>
@m1kola m1kola requested a review from a team as a code owner June 20, 2024 09:37
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.48%. Comparing base (ba8ddcb) to head (19e6d9e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #189   +/-   ##
=======================================
  Coverage   61.48%   61.48%           
=======================================
  Files          10       10           
  Lines         540      540           
=======================================
  Hits          332      332           
  Misses        192      192           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m1kola m1kola enabled auto-merge June 20, 2024 12:04
Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@m1kola m1kola added this pull request to the merge queue Jun 24, 2024
Merged via the queue into operator-framework:main with commit b2bf0d8 Jun 24, 2024
6 checks passed
@m1kola m1kola deleted the codecov_fixes branch June 24, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants