Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[revise] Remove Entity and EntitySource #95

Closed
wants to merge 1 commit into from
Closed

[revise] Remove Entity and EntitySource #95

wants to merge 1 commit into from

Conversation

varshaprasad96
Copy link
Member

Removes Entity and EntitySource. The solver takes in the Variable Source directly. The constraints, filters, sort or any transformation should be performed on variables before providing it to solver.

@varshaprasad96
[revise] Remove Entity and EntitySource
c36f273 
Removes Entity and EntitySource. The solver takes in
the Variable Source directly. The constraints, filters, sort
or any transformation should be performed on variables before
providing it to solver.

Signed-off-by: Varsha Prasad Narsing <varshaprasad96@gmail.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 2, 2023
varshaprasad96
varshaprasad96 commented May 2, 2023
View reviewed changes
pkg/ext/olm/constraints.go
"github.com/operator-framework/deppy/pkg/deppy"
)

// Question:
// These are not needed since while constructing the variables, its upto the users
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perdasilva is my understanding right?

@varshaprasad96 varshaprasad96 mentioned this pull request May 9, 2023
Closed
@awgreene awgreene mentioned this pull request May 9, 2023
Closed
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

This PR has become stale because it has been open for 30 days with no activity. Please update this PR or remove the lifecycle/stale label before it is automatically closed in 30 days. Adding the lifecycle/frozen label will cause this PR to ignore lifecycle events.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 2, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 2, 2023
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 3, 2023
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

This PR has become stale because it has been open for 30 days with no activity. Please update this PR or remove the lifecycle/stale label before it is automatically closed in 30 days. Adding the lifecycle/frozen label will cause this PR to ignore lifecycle events.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 3, 2023
@ncdc ncdc mentioned this pull request Jul 18, 2023
Merged
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

This PR has been closed as no updates were detected after 30 days of being stale. Please feel free to reopen this PR if necessary.

@github-actions github-actions bot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 3, 2023
@github-actions github-actions bot closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@varshaprasad96 @openshift-merge-robot