Skip to content

extend ActionInterface with a health checking interface #766

extend ActionInterface with a health checking interface

extend ActionInterface with a health checking interface #766

Triggered via pull request April 10, 2024 21:03
Status Failure
Total duration 3m 32s
Artifacts

ci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 1 warning
go-apidiff
Process completed with exit code 1.
Test: pkg/reconciler/internal/fake/actionclient.go#L89
cannot use &ActionClient{} (value of type *ActionClient) as "github.com/operator-framework/helm-operator-plugins/pkg/client".ActionInterface value in variable declaration: *ActionClient does not implement "github.com/operator-framework/helm-operator-plugins/pkg/client".ActionInterface (missing method CheckHealth)
Test: pkg/reconciler/internal/fake/actionclient.go#L89
cannot use &ActionClient{} (value of type *ActionClient) as "github.com/operator-framework/helm-operator-plugins/pkg/client".ActionInterface value in variable declaration: *ActionClient does not implement "github.com/operator-framework/helm-operator-plugins/pkg/client".ActionInterface (missing method CheckHealth))
Test
Process completed with exit code 2.
Lint: pkg/reconciler/internal/fake/actionclient.go#L1
: # github.com/operator-framework/helm-operator-plugins/pkg/reconciler/internal/fake
Lint: pkg/reconciler/internal/fake/actionclient.go#L89
cannot use &ActionClient{} (value of type *ActionClient) as "github.com/operator-framework/helm-operator-plugins/pkg/client".ActionInterface value in variable declaration: *ActionClient does not implement "github.com/operator-framework/helm-operator-plugins/pkg/client".ActionInterface (missing method CheckHealth) (typecheck)
Lint: pkg/reconciler/reconciler_test.go#L64
could not import github.com/operator-framework/helm-operator-plugins/pkg/reconciler/internal/fake (-: # github.com/operator-framework/helm-operator-plugins/pkg/reconciler/internal/fake
Lint: pkg/reconciler/internal/fake/actionclient.go#L89
cannot use &ActionClient{} (value of type *ActionClient) as "github.com/operator-framework/helm-operator-plugins/pkg/client".ActionInterface value in variable declaration: *ActionClient does not implement "github.com/operator-framework/helm-operator-plugins/pkg/client".ActionInterface (missing method CheckHealth)) (typecheck)
Lint: pkg/client/actionclient.go#L400
unreachable: unreachable code (govet)
Lint
issues found
Lint: pkg/client/actionclient.go#L344
unreachable-code: unreachable code after this statement (revive)