Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose wait and timeout controls for uninstall/rollbacks after install/upgrade failures #203

Closed
joelanford opened this issue Nov 7, 2022 · 1 comment

Comments

@joelanford
Copy link
Member

Currently, the built-in actionClient performs uninstalls when installs fail and rollbacks when upgrades fail, and it is hardcoded with no waits or timeouts.

We have an issue in rukpak (see operator-framework/rukpak#596), where it is desirable to be able to configure waits with timeouts on the uninstall/rollback to ensure that an uninstall/rollback completes before the next reconcile attempt starts.

I took a look at our API surface for the action config getter and the action client getter, and there isn't an obvious place to expose these knobs, so I want to start a discussion to see:

  1. Have others encountered this problem?
  2. What seems like the best place to add this functionality in the API?
@joelanford
Copy link
Member Author

A better solution solved this problem (see #196)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant