-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add various functional options to ActionConfigGetter and ActionClientGetter constructors #196
Add various functional options to ActionConfigGetter and ActionClientGetter constructors #196
Conversation
Pull Request Test Coverage Report for Build 3532484677
💛 - Coveralls |
14b86b4
to
ac91362
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
ac91362
to
2b2e7c8
Compare
New changes are detected. LGTM label has been removed. |
2b2e7c8
to
b6678ec
Compare
b6678ec
to
19764b2
Compare
19764b2
to
286a3a9
Compare
932d72c
to
a4d37a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me.
Just have a couple questions/nits that are non-blocking (they can just be deemed irrelevant and we can move forward):
…Getter constructors Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
a4d37a8
to
117a5df
Compare
defaultGetOpts []GetOption | ||
defaultInstallOpts []InstallOption | ||
defaultUpgradeOpts []UpgradeOption | ||
defaultUninstallOpts []UninstallOption | ||
|
||
installFailureUninstallOpts []UninstallOption | ||
upgradeFailureRollbackOpts []RollbackOption |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks great overall. The only thing that keeps me wondering is that I suspect the lack/presence of the default
prefix for these fields is trying to convey something, but I'm not sure what. Perhaps I'm just not familiar enough with the code...
This PR adds
In
ActionConfigGetter
constructor:action.Configuration
is generated.These are useful to give users of this library more control to decouple release storage from install namespace.
In
ActionClientGetter
constructur:action.Get
,action.Install
,action.Upgrade
,action.Uninstall
, andaction.Rollback
.These are useful to give users of this library the ability to customize how the various methods of the default
ActionInterface
interact with Helm. One example use case here is settingWait
totrue
for uninstall/rollback to ensure that subsequent reconciliations do not encounter conflicting objects that are still being deleted.Signed-off-by: Joe Lanford joe.lanford@gmail.com