-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: [not merge] - just todo's and questions #1
WIP: [not merge] - just todo's and questions #1
Conversation
/hold |
// Deprecated: --max-workers flag does not align well with the name of the option it configures on the controller | ||
// (MaxConcurrentReconciles). Flag `--max-concurrent-reconciles` should be used instead. | ||
if pflag.Lookup("max-workers").Changed { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not to do this deprecations now in SDK (ASAP)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to think about this one more. I definitely see what you're getting at (i.e. let's get --max-workers
removed before 1.0), but it's not super important for us to make this name change. We could just leave --max-workers
and revert the switch to --max-concurrent-reconciles
.
e6ce2e9
to
df28b15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I answered everything :)
Closing it since all was addressed. |
No description provided.