-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code for building and running helm operator binary #110
Add code for building and running helm operator binary #110
Conversation
Pull Request Test Coverage Report for Build 1408668137
💛 - Coveralls |
33054cb
to
38d1ff7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand it, all of this code is being moved here so that:
- We can slim down SDK repo and remove plugin implementations
- So that we can continue building the existing implementation of the bae image.
Is that right?
I'm wondering if we can dump everything from SDK into internal/legacy/*
so that we a) keep it all isolated in one place to make it easier to eventually remove and b) don't pollute the new implementation's libraries.
Lastly, what's the plan for versioning this repo if its going to contain both old and new implementations side by side?
fa48880
to
d1f2fa8
Compare
a771ec4
to
2f04ded
Compare
fe0bde3
to
9f8beb0
Compare
I think we should probably just drop the old implementation ASAP |
The PR has both the implementations merged. We have both helm and hybrid binaries built here. Since we would still continue to support helm binary, I am not moving this to the |
The following changes are made in this PR: 1. Add code for building and running helm operator binary 2. Move pkg/internal/controllerutil out of internal/ dir 3. Add separate helpers to read watches.yaml file for helm operator 4. Move `diff.go` and `types.go` from `pkg/internal` to `internal/`
Signed-off-by: varshaprasad96 <varshaprasad96@gmail.com>
Signed-off-by: varshaprasad96 <varshaprasad96@gmail.com>
Signed-off-by: varshaprasad96 <varshaprasad96@gmail.com>
9f8beb0
to
5e46b52
Compare
@joelanford @fabianvf I have moved helm related code from SDK to |
5e46b52
to
fff4b47
Compare
The following changes are made in this PR:
1. Add code for building and running helm operator binary
2. Move pkg/internal/controllerutil out of internal/ dir
3. Add separate helpers to read watches.yaml file for helm operator
4. Move
diff.go
andtypes.go
frompkg/internal
tointernal/