Support BSD sed and older bash in test rule. #112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BSD sed (as shipped with MacOS) does not support
+
nor\+
in regular expressions.However it does support
\{1,\}
which does the same thing and is also supported by GNU sed.Moreover, bash 3.2 (as shipped with MacOS) does not seem to support
source <(...)
, it seems to just do nothing.Using plain eval seems to do the trick though.
Symptom of the former issue is:
And of the latter:
(even though the binaries are fetched by
setup-envtest
)Fixes: #117