Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy Helm code base #115

Merged
merged 5 commits into from
Dec 10, 2021
Merged

Remove legacy Helm code base #115

merged 5 commits into from
Dec 10, 2021

Conversation

varshaprasad96
Copy link
Member

@varshaprasad96 varshaprasad96 commented Nov 12, 2021 •
edited
Loading

Remove legacy helm code. This PR makes the following changes:

  1. Remove legacy HelmReconciler and use HybridReconciler instead.
  2. Allow HybridReconciler to accept label selectors to allow parsing predicates while setting up controller.

Note This PR does not include change in watches.yaml of helm. As a follow-up, hybrid watches will have breaking changes to support backwards compatibility.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 12, 2021
@varshaprasad96 varshaprasad96 changed the title WIP: Remove legacy reconciler and use hybridReconciler instead Remove legacy Helm code base Nov 15, 2021
@varshaprasad96 varshaprasad96 marked this pull request as ready for review November 15, 2021 16:59
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 15, 2021
@coveralls
Copy link

coveralls commented Nov 15, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1543435695

  • 13 of 24 (54.17%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+26.1%) to 88.345%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/reconciler/reconciler.go 13 24 54.17%
Totals Coverage Status
Change from base Build 1543355069: 26.1%
Covered Lines: 1607
Relevant Lines: 1819
💛 - Coveralls

fabianvf
fabianvf approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@fabianvf fabianvf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2021
@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2021
@varshaprasad96 varshaprasad96 mentioned this pull request Dec 6, 2021
Open
10 tasks
@fabianvf fabianvf merged commit 1cdcd7f into operator-framework:main Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabianvf fabianvf fabianvf approved these changes

@joelanford joelanford Awaiting requested review from joelanford

Assignees

@fabianvf fabianvf

Labels
area/deps area/main-binary area/sdk area/testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@varshaprasad96 @coveralls @fabianvf