fix(helm-operator): do not send empty patch requests to kube apiserver #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
Pull Request Test Coverage Report for Build 1546340797
💛 - Coveralls |
joelanford
reviewed
Dec 6, 2021
The change filters out empty patches generated from the 3-way merge,
which could be in the form of the "{}" byte array that
represents an empty map.
Reference: operator-framework/operator-sdk#4957
Co-authored-by: Cheuk Lam
varshaprasad96
force-pushed
the
fix/empty-patch
branch
from
5a1d372
to
1c71b75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change filters out empty patches generated from the 3-way merge,
which could be in the form of the "{}" byte array that
represents an empty map.
Reference: operator-framework/operator-sdk#4957
Co-authored-by: Cheuk Lam