-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump kb and controller-runtime #141
chore: bump kb and controller-runtime #141
Conversation
cc: @camilamacedo86 |
Hi @varshaprasad96,
Also, I cannot see a deployment test with a project scaffold with this plugin? How do we ensure that the default scaffold is deployable on the cluster after the changes? Otherwise, the code changes shows theoretically fine. I do not know if any required changes that might be required to be done in the default scaffold were applied. I cannot really easy compare the default scaffold with these changes versus the master. WDYT? Could we track tasks for that? Have we planned to scaffold samples here already? In KB we do that with a shell script and if we would be able to do that in a simple like that would be terrific already (IMO). See: https://github.com/kubernetes-sigs/kubebuilder/blob/master/test/testdata/generate.sh /lgtm c/c @fabianvf |
@camilamacedo86 I will regenerate the samples which we have under testdata/ here. Unfortunately, we don't have e2e tests set up in the repository for now (its being tracked and will be added soon). |
Regards : #141 (comment) You are terrific folks !!! |
k8s.io/kubectl v0.22.1 | ||
sigs.k8s.io/controller-runtime v0.9.6 | ||
sigs.k8s.io/kubebuilder/v3 v3.0.0-alpha.0.0.20210716121009-fde793f20067 | ||
sigs.k8s.io/controller-runtime v0.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: bump this up to 0.10.3?
Bump: 1. Kubebuilder to 3.2.1 2. K8s dependencies to 1.22+ 4. Controller runtime to 0.10+ Signed-off-by: varshaprasad96 <varshaprasad96@gmail.com>
e5153c5
to
4dfa68f
Compare
closing this in favor of #145 |
Bump:
closes: #140
Signed-off-by: varshaprasad96 varshaprasad96@gmail.com