Merge watches for hybrid and helm

[varshaprasad96]

This PR does the following:

1. Add labelSelectors to hybrid watches
2. Remove reconcilePeriod and max-concurrent-reconciles from
   watches and instead accept it from flags.
3. Rename ChartPath to ChartDir. ChartPath also accepts directory or a chart file.

PS: follow up would be to remove legacy/watches.yaml entirely

Signed-off-by: varshaprasad96 varshaprasad96@gmail.com

[varshaprasad96]

cc: @fabianvf

[joelanford]

Remove reconcilePeriod and max-concurrent-reconciles from watches and instead accept it from flags.

@varshaprasad96 I'm curious what the motivation is for this. IIRC, these are both optional additions to the watches.yaml file and are therefore backward compatible. Is there a reason reconcile period and max concurrent reconciles can't/shouldn't be configurable on a per-GVK basis?

[coveralls]

Pull Request Test Coverage Report for Build 1577933045

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.5%) to 88.953%

---

Totals
Change from base Build 1577508140:	0.5%
Covered Lines:	1546
Relevant Lines:	1738

---

💛 - Coveralls

[fabianvf]

if w.Selector is nil does this fail with a nil pointer exception?

[varshaprasad96]

since its optional, nope. If selector is nil, we won't have predicate created to filter resources

helm-operator-plugins/pkg/reconciler/reconciler.go

Line 865 in 98d5f4f

func parsePredicateSelector(selector metav1.LabelSelector) (ctrlpredicate.Predicate, error) {