Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial on hybrid helm based operators #149

Merged

Conversation

varshaprasad96
Copy link
Member

@varshaprasad96 varshaprasad96 commented Jan 20, 2022

This PR creates a tutorial, quick overview and project
layout related doc for hybrid helm operator.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2022
@coveralls
Copy link

coveralls commented Jan 20, 2022

Pull Request Test Coverage Report for Build 1773704718

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.226%

Totals Coverage Status
Change from base Build 1773680024: 0.0%
Covered Lines: 1557
Relevant Lines: 1745

💛 - Coveralls

Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits. Looks really good on my first quick review. I will run through the tutorial steps next and comment back on anything I find while working with that.

docs/Welcome.md Outdated Show resolved Hide resolved
docs/project_layout.md Outdated Show resolved Hide resolved
docs/project_layout.md Outdated Show resolved Hide resolved
docs/project_layout.md Show resolved Hide resolved
docs/tutorial.md Outdated Show resolved Hide resolved
docs/tutorial.md Outdated Show resolved Hide resolved
docs/tutorial.md Outdated Show resolved Hide resolved
docs/tutorial.md Outdated Show resolved Hide resolved
@varshaprasad96 varshaprasad96 changed the title wip: Add tutorial on hybrid Add tutorial on hybrid helm based operators Jan 26, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2022
@varshaprasad96
Copy link
Member Author

Sample working hybrid operator built with this tutorial is here: https://github.com/varshaprasad96/hybrid-memcached-example

Copy link
Member

@asmacdo asmacdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I had 2 nits that are even more nitpicky than normal, feel free to ignore :)

docs/tutorial.md Outdated Show resolved Hide resolved
docs/tutorial.md Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2022
@asmacdo
Copy link
Member

asmacdo commented Jan 26, 2022

@varshaprasad96 The welcome page is fantastic, something our existing docs dont even have (yet) https://sdk.operatorframework.io/docs/building-operators/helm/

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2022
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2022
This PR creates a tutorial, quick overview and project
layout related doc for hybrid helm operator.

Signed-off-by: varshaprasad96 <varshaprasad96@gmail.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jan 31, 2022

New changes are detected. LGTM label has been removed.

@varshaprasad96 varshaprasad96 merged commit 0d534ef into operator-framework:main Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants