-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tutorial on hybrid helm based operators #149
Add tutorial on hybrid helm based operators #149
Conversation
Pull Request Test Coverage Report for Build 1773704718
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits. Looks really good on my first quick review. I will run through the tutorial steps next and comment back on anything I find while working with that.
392dc7d
to
cdadcd0
Compare
Sample working hybrid operator built with this tutorial is here: https://github.com/varshaprasad96/hybrid-memcached-example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I had 2 nits that are even more nitpicky than normal, feel free to ignore :)
@varshaprasad96 The welcome page is fantastic, something our existing docs dont even have (yet) https://sdk.operatorframework.io/docs/building-operators/helm/ |
cdadcd0
to
e03fdfb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This PR creates a tutorial, quick overview and project layout related doc for hybrid helm operator. Signed-off-by: varshaprasad96 <varshaprasad96@gmail.com>
e03fdfb
to
cfe07a8
Compare
New changes are detected. LGTM label has been removed. |
This PR creates a tutorial, quick overview and project
layout related doc for hybrid helm operator.