Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: parse selector in WithSelector option #154

Merged
merged 2 commits into from
Mar 2, 2022
Merged

refactor: parse selector in WithSelector option #154

merged 2 commits into from
Mar 2, 2022

Conversation

joelanford
Copy link
Member

@joelanford joelanford commented Feb 28, 2022 •
edited
Loading

This PR:

  • returns the possible error earlier (in reconciler.New rather than during SetupWithManager).
  • simplifies the logic in setupWatches
  • adds tests for the WithSelector option setup.

Signed-off-by: Joe Lanford joe.lanford@gmail.com

@joelanford
refactor: use pointer for reconciler selector
8150f5d 
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@coveralls
Copy link

coveralls commented Feb 28, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1911847157

  • 4 of 7 (57.14%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 89.568%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/reconciler/reconciler.go 4 7 57.14%
Files with Coverage Reduction New Missed Lines %
pkg/reconciler/reconciler.go 1 93.5%
Totals Coverage Status
Change from base Build 1773958737: 0.3%
Covered Lines: 1554
Relevant Lines: 1735
💛 - Coveralls

@joelanford
refactor: convert selector to predicate in WithSelector to catch erro…
4bbdd2b 
…r earlier

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
varshaprasad96
varshaprasad96 approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2022
jmrodri
jmrodri approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jmrodri jmrodri merged commit f47bc9d into operator-framework:main Mar 2, 2022
@joelanford joelanford deleted the selector-predicate branch March 2, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrodri jmrodri jmrodri approved these changes

@varshaprasad96 varshaprasad96 varshaprasad96 approved these changes

Assignees

@jmrodri jmrodri

@varshaprasad96 varshaprasad96

Labels
area/infra area/main-binary area/sdk area/testing lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joelanford @coveralls @jmrodri @varshaprasad96