Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to ginkgo/v2 #156

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Conversation

joelanford
Copy link
Member

This would be helpful for the tests being introduced in #147 because we can make use of DescribeTable functionality.

Signed-off-by: Joe Lanford joe.lanford@gmail.com

Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1928424837

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.568%

Totals Coverage Status
Change from base Build 1923150559: 0.0%
Covered Lines: 1554
Relevant Lines: 1735

💛 - Coveralls

Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2022
Copy link
Member

@varshaprasad96 varshaprasad96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@@ -1,14 +1,14 @@
module github.com/operator-framework/helm-operator-plugins

go 1.16
go 1.17
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@varshaprasad96 varshaprasad96 merged commit 6470a8f into operator-framework:main Apr 12, 2022
@joelanford joelanford deleted the ginkgo-v2 branch September 16, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants