Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add installed release manifest to more verbose logs #162

Merged
merged 7 commits into from
May 16, 2022

Conversation

everettraven
Copy link
Contributor

Description of the change

When the log level is set to be more verbose when running a hybrid operator, print the installed Helm Release manifest

Motivation for the change

resolves #14

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
pkg/watches/watches.go Outdated Show resolved Hide resolved
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@coveralls
Copy link

coveralls commented May 4, 2022

Pull Request Test Coverage Report for Build 2295946113

  • 11 of 19 (57.89%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 89.267%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/reconciler/reconciler.go 11 19 57.89%
Totals Coverage Status
Change from base Build 2260271589: -0.3%
Covered Lines: 1572
Relevant Lines: 1761

💛 - Coveralls

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Copy link
Member

@joelanford joelanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the existing helm operator, we log the diffs. That makes the difference between install and uninstall more obvious, and it makes upgrade logs actually show what changed.

https://github.com/operator-framework/operator-sdk/blob/1af83ad4d320f879e2e7af3040d0baf88eecf260/internal/helm/controller/reconcile.go#L269

Should we do that here too?

@everettraven
Copy link
Contributor Author

In the existing helm operator, we log the diffs. That makes the difference between install and uninstall more obvious, and it makes upgrade logs actually show what changed.

https://github.com/operator-framework/operator-sdk/blob/1af83ad4d320f879e2e7af3040d0baf88eecf260/internal/helm/controller/reconcile.go#L269

Should we do that here too?

I saw that but wasn't sure if that internal library was left out intentionally. I am happy to add it and make it log the diffs instead of just printing them out just plain because I agree that this makes the changes that occurred more obvious.

Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2022
@everettraven everettraven merged commit 7a3e61f into operator-framework:main May 16, 2022
@everettraven everettraven deleted the gh-14 branch May 16, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deps area/sdk lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compare the logs from SDK and this project
4 participants