-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add installed release manifest to more verbose logs #162
Conversation
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Pull Request Test Coverage Report for Build 2295946113
💛 - Coveralls |
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the existing helm operator, we log the diffs. That makes the difference between install and uninstall more obvious, and it makes upgrade logs actually show what changed.
Should we do that here too?
I saw that but wasn't sure if that internal library was left out intentionally. I am happy to add it and make it log the diffs instead of just printing them out just plain because I agree that this makes the changes that occurred more obvious. |
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Description of the change
When the log level is set to be more verbose when running a hybrid operator, print the installed Helm Release manifest
Motivation for the change
resolves #14