Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch makefile for envtest 1.24 #178

Merged
merged 2 commits into from
Jun 8, 2022
Merged

patch makefile for envtest 1.24 #178

merged 2 commits into from
Jun 8, 2022

Conversation

everettraven
Copy link
Contributor

Update the hybrid Makefile scaffold to use envtest version 1.24 instead of 1.22

@everettraven
patch makefile for envtest 1.24
9adb03b 
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
jmrodri
jmrodri approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2022
@everettraven
update testdata
6245db3 
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jun 8, 2022

New changes are detected. LGTM label has been removed.

@everettraven everettraven merged commit efd31e4 into operator-framework:main Jun 8, 2022
@everettraven everettraven deleted the patch/k8s-1.24-scaffolds branch June 8, 2022 13:47
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2461858189

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.286%
Totals Coverage Status
Change from base Build 2456454328: 0.0%
Covered Lines: 1575
Relevant Lines: 1764
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrodri jmrodri jmrodri approved these changes

@camilamacedo86 camilamacedo86 Awaiting requested review from camilamacedo86

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

Assignees

@jmrodri jmrodri

Labels
area/sdk area/testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@everettraven @coveralls @jmrodri