Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump go to 1.18 in scaffolded Dockerfile #182

Merged
merged 2 commits into from
Jun 16, 2022
Merged

bump go to 1.18 in scaffolded Dockerfile #182

merged 2 commits into from
Jun 16, 2022

Conversation

everettraven
Copy link
Contributor

We bumped Go version to 1.18 but missed the Dockerfile. This PR updates the Dockerfile to use Go 1.18.

@everettraven
bump go to 1.18 in scaffolded Dockerfile
dbfe18b 
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@everettraven
update testdata
24f9fca 
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2511275820

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.286%
Totals Coverage Status
Change from base Build 2490452431: 0.0%
Covered Lines: 1575
Relevant Lines: 1764
💛 - Coveralls

jmrodri
jmrodri approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2022
@everettraven everettraven merged commit 1a695cb into operator-framework:main Jun 16, 2022
@everettraven everettraven deleted the chore/bump-go branch June 16, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrodri jmrodri jmrodri approved these changes

Assignees

@jmrodri jmrodri

Labels
area/sdk area/testing lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@everettraven @coveralls @jmrodri