Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make a copy of rest.Config provided to k8s.io/cli-runtime. #190

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Make a copy of rest.Config provided to k8s.io/cli-runtime. #190

merged 1 commit into from
Aug 5, 2022

Conversation

porridge
Copy link
Member

@porridge porridge commented Aug 5, 2022

Fixes: #189

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2801927629

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.286%
Totals Coverage Status
Change from base Build 2792818842: 0.0%
Covered Lines: 1575
Relevant Lines: 1764
💛 - Coveralls

@porridge porridge mentioned this pull request Aug 5, 2022
Open
@joelanford
Copy link
Member

/lgtm
/approve

Don't think these actually do anything here, but 🤷‍♂️

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2022
everettraven
everettraven approved these changes Aug 5, 2022
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@everettraven
Copy link
Contributor

Will go ahead and merge. Thanks so much @porridge !

@everettraven everettraven merged commit 14db3a2 into operator-framework:main Aug 5, 2022
@porridge porridge deleted the porridge/fix-189 branch August 8, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everettraven everettraven everettraven approved these changes

@joelanford joelanford Awaiting requested review from joelanford

Assignees

@joelanford joelanford

@everettraven everettraven

Labels
area/sdk lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data race due to shared rest.Config
4 participants
@porridge @coveralls @joelanford @everettraven